Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback handling on disconnection to ATTClass::disconnect() #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add callback handling on disconnection to ATTClass::disconnect() #67

wants to merge 1 commit into from

Conversation

rmlearney-digicatapult
Copy link

@rmlearney-digicatapult rmlearney-digicatapult commented Apr 7, 2020 •
edited
Loading

Using same method as ATTClass::removeConnection.

Addresses issue #66

@rmlearney-digicatapult
Add callback handling on disconnection to ATTClass::disconnect()
66096b8 
Copying method from ATTClass::removeConnection
@facchinm
Copy link
Contributor

facchinm commented Apr 8, 2020

LGTM! @Rocketct do you have the chance to test it with sketch from #66 ?

@Rocketct Rocketct self-requested a review June 3, 2020 06:42
@rmlearney-digicatapult rmlearney-digicatapult mentioned this pull request Jun 29, 2020
Closed
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rmlearney-digicatapult
Copy link
Author

Hi is this PR still controversial?

alranel added a commit to rduino-libraries/rduinoBLE that referenced this pull request May 7, 2022
@alranel
Mention PR arduino-libraries#67 in README
d785b11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rocketct Rocketct Awaiting requested review from Rocketct

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmlearney-digicatapult @facchinm @CLAassistant